-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Version Packages (alpha) #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
changeset-release/main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+543
−13
Open
Version Packages (alpha) #2375
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 This release versions the changesets from #2286 (1823aae) but none of them declare
@modelcontextprotocol/core, sopackages/corestays at 2.0.0-alpha.1 and is not republished even though that commit changed core's public surface (removed theRequestMetaEnvelopeSchemaexport, added theSubscriptionFilter/SubscriptionsListen*schema exports) and core only bundles@modelcontextprotocol/core-internalas a devDependency, so its bundled schemas will diverge from client/server@2.0.0-alpha.4. Add a changeset onmaindeclaring@modelcontextprotocol/core(e.g. major) so this auto-generated release PR is regenerated with a core bump before merging.Extended reasoning...
What the bug is. This Version Packages PR consumes the ~70 changesets added by #2286 (commit
1823aae), bumping client/server/middleware to2.0.0-alpha.4, codemod toalpha.2, and core-internal toalpha.3. However, none of those changesets declare@modelcontextprotocol/core. Changesets therefore produces no bump for it:packages/core/package.jsonandpackages/core/CHANGELOG.mdare absent from this PR's changed files, andchangeset publishwill skip core because its version (2.0.0-alpha.1) is unchanged on the registry.Why core actually needs a bump. Commit
1823aaeis not neutral toward core's published surface:packages/core/src/index.tswas modified by that commit — it removes the publicRequestMetaEnvelopeSchemaexport (a breaking removal) and adds seven new exports (SubscriptionFilterSchema, theSubscriptionsListen*request/result schemas, and theSubscriptionsAcknowledged*notification schemas).@modelcontextprotocol/corelists@modelcontextprotocol/core-internalonly as a devDependency (it is bundled at build time), so changesets'updateInternalDependenciespropagation cannot carry the core-internal major bump (strictEmptyResultSchema, requiredCallToolResult.content, re-scopedspecTypeSchemas) into core either.Why nothing else prevents it. The only changeset that has ever named
@modelcontextprotocol/coreisadd-core-public-package, which was already consumed in the previous release (it produced core@2.0.0-alpha.1 and appears inpre.jsonas a pre-existing entry, not one added here)..changeset/config.jsonhas no fixed/linked groups containing core and core is not in theignorelist, and core is publishable (access: public, noprivateflag) — so the omission is simply a missing changeset, not an intentional exclusion.Step-by-step impact after merging this PR as-is. (1) The release publishes
@modelcontextprotocol/client@2.0.0-alpha.4and@modelcontextprotocol/server@2.0.0-alpha.4, whose wire behavior reflects the per-era codec split (e.g.CallToolResult.contentnow required,EmptyResultSchemastrict). (2)@modelcontextprotocol/coreremains2.0.0-alpha.1on npm, built from the pre-#2286 sources: it still exportsRequestMetaEnvelopeSchema, lacks the newSubscriptions*/SubscriptionFilterschemas, and its bundled core-internal schemas still defaultcontent: []and acceptresultTypeon neutral results. (3) A consumer that follows the codemod guidance from #2354 — importing canonical Zod schemas from@modelcontextprotocol/corewhile running client/server at alpha.4 — gets schemas that disagree with what the alpha.4 client/server actually accept or emit on the wire. (4) The breaking removal ofRequestMetaEnvelopeSchemaships in source but is recorded in no CHANGELOG and never reaches npm, so when core is eventually bumped the removal will appear without the changelog trail.How to fix. Since this PR is auto-generated by the Changesets action, the fix lands on
main: add a changeset declaring@modelcontextprotocol/core(major, given the export removal and the bundled wire-schema breaks; minor at minimum) describing the removedRequestMetaEnvelopeSchemaexport and the new subscription schema exports. The action will then regenerate this release PR with@modelcontextprotocol/core@2.0.0-alpha.2(or the appropriate pre-version) included, keeping the published package set mutually consistent. This release PR should not be merged until that changeset is in place.