Skip to content

fix: standardize resource not found error code #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CrypticCortex wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: standardize resource not found error code #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mcp-core/src/main/java/io/modelcontextprotocol/spec/McpSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public static final class ErrorCodes {
/**
* Resource not found.
*/
public static final int RESOURCE_NOT_FOUND = -32002;
public static final int RESOURCE_NOT_FOUND = INVALID_PARAMS;

/**
* URL elicitation is required before the request can proceed.
Expand Down
2 changes: 1 addition & 1 deletion mcp-core/src/test/java/io/modelcontextprotocol/spec/McpErrorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void testNotFound() {
String uri = "file:///nonexistent.txt";
McpError mcpError = McpError.RESOURCE_NOT_FOUND.apply(uri);
assertNotNull(mcpError.getJsonRpcError());
assertEquals(-32002, mcpError.getJsonRpcError().code());
assertEquals(McpSchema.ErrorCodes.INVALID_PARAMS, mcpError.getJsonRpcError().code());
assertEquals("Resource not found", mcpError.getJsonRpcError().message());
assertEquals(Map.of("uri", uri), mcpError.getJsonRpcError().data());
}
Expand Down