mcp: remove support for batching on streamable connections#948
Conversation
|
Thanks for the contribution. We're still analyzing our backwards compatibility stance on this and when exactly we would like to remove it. I'll update you when this is resolved. |
|
Conceptually this looks right for #911: dropping GitHub shows the branch as conflicting with current After rebase, one thing I'd sanity-check: any remaining callers that still assumed batch decode on the stateless POST probe path. |
Batching was already deprecated and rejected for protocol versions >= 2025-06-18. Remove it entirely to simplify the streamable transport code. Replace readBatch calls with single message decoding, remove batch-related checks and comments, and delete batch-specific tests. Closes modelcontextprotocol#911 Signed-off-by: wucm667 <stevenwucongmin@gmail.com>
28dce5c to
3840846
Compare
|
Rebased onto latest main and pushed. All CI checks are green. Regarding the stateless POST probe path — ephemeralConnectOpts now uses jsonrpc2.DecodeMessage directly instead of readBatch, so there's no batch decode assumption left. @maciej-kisiel mentioned they're still evaluating the backwards compatibility stance. Let me know if you have any other concerns. |
Fixes #911
Batching was already deprecated and rejected for protocol versions >= 2025-06-18.
Remove it entirely to simplify the streamable transport code.
Replaces
readBatchcalls with single message decoding, removes batch-relatedchecks and comments, and deletes batch-specific tests. No behavioral change for
single-message requests.