feat: CIMD support check for authorization-server metadata (supersedes #235)#365
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #235 by @tnorimat. Original commit cherry-picked with authorship preserved (
0c17d8f), rebased onto currentmain(post-#364), with the unrelatedsrc/checks/client.tschange dropped and the version-gating reworked.What this adds
A second check on the
authorization-server-metadata-endpointscenario that verifies the AS metadata advertisesclient_id_metadata_document_supported: true(Client ID Metadata Document support). EmitsWARNINGwhen absent orfalse— CIMD support is SHOULD in MCP 2025-11-25, not MUST.Per-check spec-version gating
Rather than threading
specVersionintorun()and branching on=== '2025-11-25', this introduces an optionalConformanceCheck.sourcefield (same{introducedIn, removedIn}shape scenarios already use). The runner filters returned checks against--spec-versionusing the existingmatchesSpecVersioncomparator. Scenarios emit all their checks unconditionally; the runner decides which apply.The CIMD check is tagged
source: { introducedIn: '2025-11-25' }, so it's reported for--spec-version 2025-11-25anddraft, and dropped for earlier versions.Changes vs #235
src/checks/client.ts/checks.test.tshunks dropped — out of scope (downgraded MUST-level initialization checks to WARNING)FAILURE→WARNING(SHOULD-level requirement)SpecReferences.MCP_CLIENT_ID_METADATA_DOCUMENTS/IETF_CIMDconstantscheck.sourceinstead of a runtimespecVersion === '2025-11-25'branch and the associatedrun()signature changeCloses #235. Closes #234.