feat: add JSON-based setup option to authorization server conformance…#228
Closed
Michito-Okai wants to merge 1 commit into
Closed
feat: add JSON-based setup option to authorization server conformance…#228Michito-Okai wants to merge 1 commit into
Michito-Okai wants to merge 1 commit into
Conversation
commit: |
9 tasks
pcarleton
added a commit
that referenced
this pull request
Jun 24, 2026
…persedes #228) (#360) * feat: add JSON-based setup option to authorization server conformance test * refactor(auth): single-schema validation for --file; drop duplicate schema/merge * chore: move authorization-server settings sample to examples/ * test(auth): cover --file merge precedence and validation * fix(auth): validate --file standalone via .strict(); reject partial/typo'd files The settings file must be a complete, valid AuthorizationServerOptions on its own; CLI flags are optional overrides on top. .strict() rejects unknown keys so a typo'd field surfaces as an error instead of being silently ignored. ZodError from file parsing is reported with the file path. * chore: drop placeholder --file merge test pending CLI test pattern The test re-implemented the merge logic locally, which can drift from src/index.ts. Proper coverage needs either programmatic commander.parse() or an extracted loadAuthorizationServerOptions() helper; deferring that decision to a follow-up rather than establishing the pattern here. --------- Co-authored-by: Michito Okai <michito.okai.zn@hitachi.com>
Member
|
I needed to rebase, so i scooted this to #360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Described in #225
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist