🧪 [testing improvement] Add tests for GitHubModSource.ListPlugins#7
🧪 [testing improvement] Add tests for GitHubModSource.ListPlugins#7mleem97 wants to merge 2 commits into
Conversation
🎯 **What:** The testing gap addressed: Missing Test for GitHubModSource.ListPlugins method which returns a deterministic list based on internal hardcoded data. 📊 **Coverage:** Covered the deterministic behavior of mapping repos. Asserts exactly 4 elements are mapped. Asserts specific ids, versions and channels properties are accurately set. Covers the edge case where '-DataCenter-ModLoader' is properly aliased to 'SteamPlugin'. ✨ **Result:** Increased test coverage by providing safety net unit tests for the GitHub channel source.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…and remove reflection JSON parsing causing IL2026 🎯 **What:** CI failed with `MSBuild MSB1009` because the REPO_ROOT path resolution in the Linux shell script was missing one level (`/../../..`), leading to resolving the `build` directory as root. Furthermore, `TelemetryService.cs` used `JsonSerializer.Serialize` reflection overloads causing an `IL2026` warning. 📊 **Coverage:** Adjusted path variable inside `build-avalonia-packages.sh`. Converted the telemetry payload to explicit statically typed DTO `StartupEvent` and used pattern matching to select generated `AppJsonContext` serializers. ✨ **Result:** Both the Linux CI runner building artifacts and the `net9.0` trimmer step correctly execute.
1 participant
🎯 What: The testing gap addressed: Missing Test for GitHubModSource.ListPlugins method which returns a deterministic list based on internal hardcoded data.
📊 Coverage: Covered the deterministic behavior of mapping repos. Asserts exactly 4 elements are mapped. Asserts specific ids, versions and channels properties are accurately set. Covers the edge case where
-DataCenter-ModLoaderis properly aliased toSteamPlugin.✨ Result: Increased test coverage by providing safety net unit tests for the GitHub channel source.
PR created automatically by Jules for task 8576816269377135985 started by @mleem97