🔒 [security fix] Fix potential argument injection in SafeProcess#14
🔒 [security fix] Fix potential argument injection in SafeProcess#14mleem97 wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The
SafeProcess.OpenFolderandSafeProcess.OpenExplorerAndSelectmethods were using string interpolation to concatenate arguments, which could lead to argument injection if a folder or file path contained unescaped double quotes (e.g.path = "C:\\\" calc.exe").explorer.exeor result in arbitrary processes being launched, leading to remote code execution (RCE) or local privilege escalation depending on the context.🛡️ Solution: Modified the methods to use
ArgumentListrather than theArgumentsproperty ofProcessStartInfo.ArgumentListsafely handles quoting and escaping arguments, mitigating argument injection vulnerabilities entirely.PR created automatically by Jules for task 14594577057668410129 started by @mleem97