Skip to content

🧹 Fix swallowed exceptions in BetterAuthService#11

Open
mleem97 wants to merge 2 commits into
mainfrom
fix-swallowed-exceptions-in-better-auth-service-12354467878709416632
Open

🧹 Fix swallowed exceptions in BetterAuthService#11
mleem97 wants to merge 2 commits into
mainfrom
fix-swallowed-exceptions-in-better-auth-service-12354467878709416632

Conversation

@mleem97
Copy link
Copy Markdown
Owner

@mleem97 mleem97 commented May 21, 2026

🎯 What: Modified BetterAuthService.cs to explicitly log exceptions using AppFileLog.Error instead of swallowing them with empty or comment-only catch blocks.
💡 Why: Silently caught exceptions hide failures, making debugging and troubleshooting authentication issues extremely difficult. Logging them ensures any failures during login or session verification are captured.
Verification: Re-compiled the project and ran the GregModmanager.Tests suite to ensure no tests or core behavior was broken.
Result: Improved maintainability and traceability of the BetterAuthService without affecting its external behavior.


PR created automatically by Jules for task 12354467878709416632 started by @mleem97

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant