Skip to content

fix(sonar): fix security issues and correct S5738 suppression#810

Merged
mivek merged 1 commit into
mainfrom
fix/sonar-security-issues
May 31, 2026
Merged

fix(sonar): fix security issues and correct S5738 suppression#810
mivek merged 1 commit into
mainfrom
fix/sonar-security-issues

Conversation

@mivek
Copy link
Copy Markdown
Owner

@mivek mivek commented May 31, 2026

  • Fix S5738: replace @SuppressWarnings("java:S1874") with "java:S5738" in MessagesTest — S5738 covers deprecated-for-removal methods
  • Fix S8543 (release.yml): use npm ci --ignore-scripts to lock npm deps
  • Fix S6505 (validate-commit.yml): add --ignore-scripts to npm install commands to prevent execution of arbitrary lifecycle scripts
  • Fix S7637 (comment-pr.yml, lint-pr.yml): pin GitHub Actions to full commit SHAs to prevent supply-chain attacks
    • marocchino/sticky-pull-request-comment@v3 → SHA 0ea0beb (v3.0.4)
    • amannn/action-semantic-pull-request@v6.1.1 → SHA 48f2562

@github-actions
Copy link
Copy Markdown

Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue.

- Fix S5738: replace @SuppressWarnings("java:S1874") with "java:S5738" in
  MessagesTest — S5738 covers deprecated-for-removal methods
- Fix S8543 (release.yml): use npm ci --ignore-scripts to lock npm deps
- Fix S6505 (validate-commit.yml): add --ignore-scripts to npm install commands
  to prevent execution of arbitrary lifecycle scripts
- Fix S7637 (comment-pr.yml, lint-pr.yml): pin GitHub Actions to full commit
  SHAs to prevent supply-chain attacks
  - marocchino/sticky-pull-request-comment@v3 → SHA 0ea0beb (v3.0.4)
  - amannn/action-semantic-pull-request@v6.1.1 → SHA 48f2562
@mivek mivek force-pushed the fix/sonar-security-issues branch from 1ef5675 to aa81fff Compare May 31, 2026 13:55
@sonarqubecloud
Copy link
Copy Markdown

@mivek mivek merged commit 9340d30 into main May 31, 2026
9 checks passed
@mivek mivek deleted the fix/sonar-security-issues branch May 31, 2026 14:10
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.26.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant