fix: resolve hanging tight loop on windows#1873
Merged
Merged
Conversation
martin-helmich
approved these changes
May 31, 2026
Member
martin-helmich
left a comment
martin-helmich
left a comment
There was a problem hiding this comment.
Feeling a bit stupid about this one... 🤦♂️
Anyway, good catch. 🫶
martin-helmich
changed the title
Member
|
Noticed that this is still a draft PR; any objections to merging this? |
Contributor
Author
Final testing, this was just throwing the fix into PR before weekend 🍻 . Will mark as ready and merge when this is working on windows fresh install with fix ( without all my debug clutter ). Although this is obviously right i want to check for regressions regarding all those tty flush red herings 😜 |
Contributor
Author
|
Final test done. No more changes besides these needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found it! Lets fix it! Lets get rolling again on Windows! 🚀