Skip to content
This repository was archived by the owner on Jun 12, 2024. It is now read-only.

1.7.0 Compatibility Initial draft#2

Open
mxszym-dolby wants to merge 2 commits into
devfrom
bump-1.7.0
Open

1.7.0 Compatibility Initial draft#2
mxszym-dolby wants to merge 2 commits into
devfrom
bump-1.7.0

Conversation

@mxszym-dolby

Copy link
Copy Markdown
  • Add a Kotlin compatibility layer required to use the 1.7.0 Millicast SDK
  • Refactor the publisher/subscriber methods in the MillicastManager to work asynchronously with Promises
  • Fix imports to match the new package paths in 1.7.0

This is the initial working version, more cleanups are required, but the PR is already quite large, so after this one a net one will come with, among others

  • Some synchronous methods that used to return boolean now work async and return void, to be fixed
  • NDI support temporarily not working, to be fixed

Comment thread app/build.gradle Outdated
id 'org.jetbrains.kotlin.android'
}


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unecessary empty lines

Comment thread app/build.gradle Outdated
}
}
compileSdkVersion 31
compileSdkVersion 33

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be focusing on Android 34

@mxszym-dolby mxszym-dolby marked this pull request as ready for review February 7, 2024 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants