Align pattern support with node-level checks (scoped 15-pattern rules)#1020
Open
fangyangci wants to merge 6 commits into
Open
Align pattern support with node-level checks (scoped 15-pattern rules)#1020fangyangci wants to merge 6 commits into
fangyangci wants to merge 6 commits into
Conversation
a06949d to
c26b180
Compare
DingmaomaoBJTU
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the logic statically (didn't run the suite). Overall the rules-first prefilter plus the sys_info / yield_skipped cleanups look coherent — I verified no remaining callers pass the removed sys_info/yield_skipped args, device_type.name is the right value to feed RuntimeCheckerQuery, and the synthetic check_result shape matches the real {compile, run} one. Left inline notes; the main one is a design question about skipping the real EP run purely on node-level rules.
Two nits not worth their own threads: available_ops_all.json gained two trailing blank lines at EOF, and _RulesPrefilterProtocol's method body reads better as ... than pass.
…ngyangci/subgraph_pattern
…osoft/winml-cli into fangyangci/subgraph_pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifact pattern generate:https://github.com/gim-home/ModelKitArtifacts/pull/156
Summary
check_resultoutput via centralized sanitization and backward-compatible import path.Scope
available_ops_all.jsonhas 19 pattern definitions in total.Consistency Note
Validation
uv run ruff check src/winml/modelkit/analyze src/winml/modelkit/pattern tests/unit/analyzeuv run mypy -p winml.modelkituv run pytest tests/unit/analyze/runtime_checker/test_ep_checker.py tests/unit/analyze/test_check_ops.py -q