Skip to content

AHP: opt into SDK managed-settings self-fetch#323651

Merged
vijayupadya merged 2 commits into
mainfrom
agents/managed-settings-ahp-opt-in
Jul 10, 2026
Merged

AHP: opt into SDK managed-settings self-fetch#323651
vijayupadya merged 2 commits into
mainfrom
agents/managed-settings-ahp-opt-in

Conversation

@joshspicer

@joshspicer joshspicer commented Jun 30, 2026

Copy link
Copy Markdown
Member

AHP: opt into SDK managed-settings self-fetch

see https://github.com/github/copilot-sdk-internal/issues/206

The Agent Host session launcher passes enableManagedSettings: true when creating a Copilot SDK session, so the runtime self-fetches and enforces enterprise managed settings (bypass-permissions policy) using the session's GitHub token — no enforcement logic lives in VS Code.

  • src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts — set enableManagedSettings: true in _buildSessionConfig. Typed via the SDK's SessionConfigBase (see SDK PR).

Related PRs


⚠️ Draft — part of a 3-repo change (runtime + SDK + VS Code).

Copilot AI review requested due to automatic review settings June 30, 2026 01:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agent Host (AHP) Copilot session launcher to opt Copilot SDK sessions into runtime-managed enterprise policy enforcement by enabling the SDK/session flag for self-fetching managed settings at bootstrap time.

Changes:

  • Enable selfFetchManagedSettings: true in the session config built by CopilotSessionLauncher.
  • Document (in-code) that the runtime will self-fetch managed settings and enforce them before the first turn.
Show a summary per file
File Description
src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts Adds selfFetchManagedSettings: true to the SDK session config built during session launch.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts Outdated
Pass selfFetchManagedSettings:true in session.create params so the
runtime self-fetches enterprise bypass-permissions policy from the
GitHub managed_settings endpoint at session bootstrap. The runtime
enforces the result fail-closed before the first turn.

Requires: github/copilot-agent-runtime#agents/managed-settings-sdk-capability
@joshspicer joshspicer force-pushed the agents/managed-settings-ahp-opt-in branch from 18ffce7 to b0da539 Compare June 30, 2026 20:35
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Base: ca748574 Current: a88cd7ae

No screenshot changes.

@digitarald

Copy link
Copy Markdown
Contributor

Latest flag is enableManagedSettings

@vijayupadya vijayupadya marked this pull request as ready for review July 10, 2026 06:39
@vijayupadya vijayupadya enabled auto-merge (squash) July 10, 2026 06:39
@vijayupadya vijayupadya marked this pull request as draft July 10, 2026 06:40
auto-merge was automatically disabled July 10, 2026 06:40

Pull request was converted to draft

@vijayupadya vijayupadya marked this pull request as ready for review July 10, 2026 06:40
@vijayupadya vijayupadya enabled auto-merge (squash) July 10, 2026 06:41
@vijayupadya vijayupadya requested review from vijayupadya and removed request for vijayupadya July 10, 2026 06:41
@vijayupadya vijayupadya merged commit 9370f6c into main Jul 10, 2026
29 checks passed
@vijayupadya vijayupadya deleted the agents/managed-settings-ahp-opt-in branch July 10, 2026 07:24
@vs-code-engineering vs-code-engineering Bot added this to the 1.129.0 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants