fix: remove duplicate Enum entry in CompletionItemKinds mapping#322700
Open
jachinsamuel wants to merge 1 commit into
Open
fix: remove duplicate Enum entry in CompletionItemKinds mapping#322700jachinsamuel wants to merge 1 commit into
jachinsamuel wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the CompletionItemKinds icon mapping in src/vs/editor/common/languages.ts by removing a duplicate CompletionItemKind.Enum entry from the internal byKind map, ensuring each kind is mapped only once.
Changes:
- Removed the redundant
byKind.set(CompletionItemKind.Enum, Codicon.symbolEnum);entry so thebyKindmap contains a single mapping forCompletionItemKind.Enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a duplicate registration of the
CompletionItemKind.Enumicon mapping in theCompletionItemKindsnamespace'sbyKindMap (originally lines 405 and 407 insrc/vs/editor/common/languages.ts). Removing the duplicate ensures the mapping holds unique entries.How to test
Verify in
src/vs/editor/common/languages.tsthat the duplicatebyKind.set(CompletionItemKind.Enum, Codicon.symbolEnum);line has been removed and all otherCompletionItemKindvalues remain mapped.