Skip to content

Update customizations sidebar content and behavior#322497

Open
hawkticehurst wants to merge 5 commits into
mainfrom
agents/update-agents-sidebar-customizations-8c1e9ed8
Open

Update customizations sidebar content and behavior#322497
hawkticehurst wants to merge 5 commits into
mainfrom
agents/update-agents-sidebar-customizations-8c1e9ed8

Conversation

@hawkticehurst

@hawkticehurst hawkticehurst commented Jun 23, 2026

Copy link
Copy Markdown
Member

Fixes #321166

Addresses bug where the Customizations sidebar list items, when clicked, do not open their associated Customizations modal page.

This is accomplished by rethinking Customizations sidebar a bit to match the behavior of the Checks section UI that is displayed in chat sessions that have PRs with CI tasks.

Specific changes:

  • Customizations section is collapsible and resizable
    • Min height visually matches Checks section min height
    • Initial height and max height are the total height of content
  • Added an "Overview" list item to access the Overview page directly
  • Change Customizations label font size to match Checks (i.e. make it smaller by 1px)
  • Remove sessions.customizations.sidebarMode setting and associated code for "single" option
Screen.Recording.2026-06-23.at.12.16.48.AM.mov
Screen.Recording.2026-06-23.at.2.22.40.PM.mov

@hawkticehurst hawkticehurst self-assigned this Jun 23, 2026
Copilot AI review requested due to automatic review settings June 23, 2026 04:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agents window “Customizations” sidebar section to behave more like the Checks UI: it becomes vertically resizable, adds a dedicated “Overview” entry, and fixes deep-linking so clicking a customization category opens the Customizations editor with that section selected (addressing #321166).

Changes:

  • Reworks sidebar layout to use a vertical SplitView, making Customizations non-collapsible and resizable with a defined minimum height.
  • Adds an “Overview” sidebar entry and updates navigation actions so category clicks consistently deep-link to their corresponding editor section.
  • Adjusts Customizations toolbar rendering/styling to be height-aware and scroll correctly within the resizable pane.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/sessions/contrib/sessions/test/browser/aiCustomizationShortcutsWidget.fixture.ts Updates screenshot fixtures to include the new Overview entry and new minimum-height behavior.
src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts Introduces a vertical SplitView to make the Customizations section resizable and layout-driven.
src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css Adds SplitView container styling and insets the separator/sash to match the intended visuals.
src/vs/sessions/contrib/sessions/browser/media/customizationsToolbar.css Refactors Customizations toolbar CSS to fill available height and support scrolling within the pane.
src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts Adds Overview action/entry and ensures category actions deep-link to sections (fixing the selection bug).
src/vs/sessions/contrib/sessions/browser/aiCustomizationShortcutsWidget.ts Reworks widget DOM to remove collapsing, add scrollable content, and expose desired-height changes.
src/vs/sessions/AI_CUSTOMIZATIONS.md Updates documentation to reflect the new resizable behavior and Overview + deep-link semantics.

Comment thread src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts Outdated
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 48dd21f8 Current: d8191924

Changed (6)

sessions/aiCustomizationShortcutsWidget/Expanded/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/Expanded/Light
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithCounts/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithCounts/Light
Before After
before after

Added (4)

sessions/aiCustomizationShortcutsWidget/MinimumHeight/Dark

current

sessions/aiCustomizationShortcutsWidget/MinimumHeight/Light

current

sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Dark

current

sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Light

current

Removed (12)

sessions/aiCustomizationShortcutsWidget/Collapsed/Dark

baseline

sessions/aiCustomizationShortcutsWidget/Collapsed/Light

baseline

sessions/aiCustomizationShortcutsWidget/CollapsedWithMcpServers/Dark

baseline

sessions/aiCustomizationShortcutsWidget/CollapsedWithMcpServers/Light

baseline

sessions/aiCustomizationShortcutsWidget/ModeWelcome/Dark

baseline

sessions/aiCustomizationShortcutsWidget/ModeWelcome/Light

baseline

sessions/aiCustomizationShortcutsWidget/ModeSection/Dark

baseline

sessions/aiCustomizationShortcutsWidget/ModeSection/Light

baseline

sessions/aiCustomizationShortcutsWidget/ModeSingle/Dark

baseline

sessions/aiCustomizationShortcutsWidget/ModeSingle/Light

baseline

sessions/aiCustomizationShortcutsWidget/ModeSingleEmpty/Dark

baseline

sessions/aiCustomizationShortcutsWidget/ModeSingleEmpty/Light

baseline

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hawkticehurst hawkticehurst marked this pull request as ready for review June 23, 2026 04:31
@hawkticehurst hawkticehurst requested review from benibenj and removed request for osortega June 23, 2026 04:35
Comment thread src/vs/sessions/contrib/sessions/browser/aiCustomizationShortcutsWidget.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Comment thread src/vs/sessions/AI_CUSTOMIZATIONS.md
@hawkticehurst hawkticehurst requested a review from benibenj June 23, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents window customizations dialog does not select clicked section

3 participants