Skip to content

Fix status check deduplication dropping checks from different workflow events#8663

Merged
alexr00 merged 3 commits intomainfrom
copilot/fix-extension-pr-checks
Apr 15, 2026
Merged

Fix status check deduplication dropping checks from different workflow events#8663
alexr00 merged 3 commits intomainfrom
copilot/fix-extension-pr-checks

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

When the same workflow triggers on both push and pull_request, the resulting check runs share the same name but are distinct checks. deduplicateStatusChecks keyed only on context (the check run name), collapsing e.g. 4 checks into 2.

Changes

  • src/github/githubRepository.ts: Include event and workflowName in the deduplication key so checks from different trigger events or different workflows are preserved:

    const key = `${status.context}\0${status.event ?? ''}\0${status.workflowName ?? ''}`;

    Re-runs of the same check (same name + event + workflow) are still correctly deduplicated.

  • src/test/github/githubRepository.test.ts: Added tests covering different events kept separate, same-event deduplication, different workflows kept separate, and pending-over-completed preference.

Copilot AI linked an issue Apr 14, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits April 14, 2026 10:06
Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/588c7904-b943-44bc-842d-b78baf609a0a

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
When the same workflow runs for both push and pull_request events,
checks with the same name but different events were incorrectly merged
during deduplication. Now the deduplication key includes the event
and workflowName fields so distinct checks are preserved.

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/588c7904-b943-44bc-842d-b78baf609a0a

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix extension not showing all PR checks Fix status check deduplication dropping checks from different workflow events Apr 14, 2026
Copilot AI requested a review from alexr00 April 14, 2026 10:12
@alexr00 alexr00 marked this pull request as ready for review April 15, 2026 16:14
Copilot AI review requested due to automatic review settings April 15, 2026 16:14
@alexr00 alexr00 enabled auto-merge (squash) April 15, 2026 16:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes status check deduplication so that check runs with the same name coming from different workflow trigger events (e.g. push vs pull_request) or different workflows are preserved instead of being collapsed.

Changes:

  • Update deduplicateStatusChecks to key by context + event + workflowName rather than context alone.
  • Add unit tests to validate deduplication behavior across events/workflows and pending-vs-completed selection.
  • Update proposed VS Code chat session typings to deprecate initialSessionOptions and introduce inputState.
Show a summary per file
File Description
src/github/githubRepository.ts Expands the deduplication key to include event and workflowName so distinct checks aren’t merged.
src/test/github/githubRepository.test.ts Adds tests exercising the updated deduplication rules (events/workflows/pending preference).
src/@types/vscode.proposed.chatSessionsProvider.d.ts Adjusts proposed API typings: deprecates initialSessionOptions and adds inputState.

Copilot's findings

  • Files reviewed: 2/3 changed files
  • Comments generated: 4

Comment thread src/github/githubRepository.ts
Comment thread src/github/githubRepository.ts
Comment thread src/test/github/githubRepository.test.ts
Comment thread src/test/github/githubRepository.test.ts
@alexr00 alexr00 merged commit eacf539 into main Apr 15, 2026
7 checks passed
@alexr00 alexr00 deleted the copilot/fix-extension-pr-checks branch April 15, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension does not show all PR checks

4 participants