Stop automatically cancelling the previous Find All References based request when a new one comes in.#14457
Draft
sean-mcmanus wants to merge 4 commits into
Draft
Stop automatically cancelling the previous Find All References based request when a new one comes in.#14457sean-mcmanus wants to merge 4 commits into
sean-mcmanus wants to merge 4 commits into
Conversation
…request when a new one comes in.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I still need to test/review it more (it seemed to fix the case that was broken previously). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix microsoft/vscode#316783 (where Copilot and user requested find all references based operations would cancel one other due to the code cancelling the previous request), assuming VS Code can't provide a better fix.
The problem with this change is that the previous requests are "lost" and never shown when manually invoked, so users have to know they should manually cancel the previous one now or it's a waste of time waiting for it to finish.