Reporter overhaul (6/6): performance budgets and daemon-aligned major default flip#5870
Open
TheLarkInn wants to merge 4 commits into
Open
Reporter overhaul (6/6): performance budgets and daemon-aligned major default flip#5870TheLarkInn wants to merge 4 commits into
TheLarkInn wants to merge 4 commits into
Conversation
TheLarkInn
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
This was referenced Jul 15, 2026
Encode the specification §7.3 blocking budgets (3% wall-time regression, 32 MiB peak memory, 10 Hz interactive refresh, 64 KiB AI output, 20 AI detailed diagnostics) as shared data in a new perf module, with helpers for benchmark harnesses and capacity tests. Add a getPendingEventCount observability hook to ReporterManager to prove bounded streaming, and a Performance test suite covering the budgets, bounded streaming, a high-volume benchmark, queue-pressure protected-event preservation, and status coalescing. Assistant-model: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 897dcf7e-e6e8-4a84-85ca-34b93fa29be3
Assistant-model: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 897dcf7e-e6e8-4a84-85ca-34b93fa29be3
Encode the specification §8.1 phase 6 default flip as revertible data in a new migration module: the seven migration phases (each independently releasable and revertible), pre-flip and daemon-aligned major default sets (automatic selection on by default, legacy terminal APIs removed, incompatible plugins gated before apply, legacy renderer/aliases/sentinel bridge retained, RUSH_REPORTER=legacy emergency fallback), and a plugin apply gate that fails incompatible plugins with a structured RUSH_PLUGIN_API_INCOMPATIBLE diagnostic. Completes the Rush Reporter Overhaul (28/28). Assistant-model: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 897dcf7e-e6e8-4a84-85ca-34b93fa29be3
Assistant-model: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 897dcf7e-e6e8-4a84-85ca-34b93fa29be3
TheLarkInn
force-pushed
the
reporter/5-heft-protocol
branch
from
95b3891 to
be13212
Compare
TheLarkInn
force-pushed
the
reporter/6-perf-and-default-flip
branch
from
1defeea to
6f4808f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Reporter Overhaul PR stack (merge bottom-up)
mainEach PR's diff is scoped to its phase; review independently, merge from #5865 upward.
👉 This is PR 6 of 6.
Phase 6 — Performance budgets & daemon-aligned major default flip (RFC §7.3, §8.1)
Encodes the P0 performance/capacity budgets and models the major-release default flip.
What's included
REPORTER_PERFORMANCE_BUDGETS(≤3% wall-time regression, ≤32 MiB peak memory, bounded streaming, 10 Hz interactive refresh, 64 KiB AI output) + wall-time/memory helpers and aReporterManager.getPendingEventCount()observability hook. Benchmark, queue-pressure, and status-coalescing tests prove bounded streaming and no loss of protected events.apply()with a structuredRUSH_PLUGIN_API_INCOMPATIBLEdiagnostic), while the legacy renderer, verbosity aliases, andRUSH_REPORTER=legacyemergency fallback are retained.Validation
rush build --to @rushstack/reporter✅rush test --only @rushstack/reporter✅ (adds Performance and Migration suites)@beta. Completes the RFC (28/28 features).Scope note
Standalone package; not yet wired into the live CLI. Independently releasable/revertible per RFC §8.1.