give sign up link darker outline#11419
Open
srietkerk wants to merge 1 commit into
Open
Conversation
… the sign in modal
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sign-in modal’s “Sign up / Sign in” switch link focus styling to provide a more visible keyboard focus outline, aligning with the linked accessibility/style issue in the micro:bit target.
Changes:
- Adds a custom
:focus-visibleoutline style for.link-buttonwithin the sign-in modal footer switch area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#6824
When I was first addressing the issue, I thought that the underline was a good enough indicator for the sign up link, but we should be consistent with our styling. The link now looks like this when tabbed onto it: