Improve toggle field editor for screen reader users#11417
Open
microbit-robert wants to merge 1 commit into
Open
Improve toggle field editor for screen reader users#11417microbit-robert wants to merge 1 commit into
microbit-robert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a field editor that is edited immediately with 'Enter' or 'Space' rather than popping up an editable element or dialog. As a result, it needs a slightly different approach to other field editors. This moves the aria-label into a child element as text and attaches an aria-live attribute to the focusable element. This ensures that the value is output correctly on initial focus and also provides feedback to the user when they change the value of the toggle.