Add async operation SMART scope ADR#5656
Draft
mikaelweave wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
=======================================
Coverage ? 77.56%
=======================================
Files ? 1004
Lines ? 36859
Branches ? 5587
=======================================
Hits ? 28590
Misses ? 6917
Partials ? 1352 🚀 New features to boost your workflow:
|
Require SMART system scopes for async job status and cancellation. Export status validates resource metadata while other async operations require all-resource read/write access. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| private IAuthorizationService<DataActions> _authorizationService; | ||
| private IQueueClient _queueClient; | ||
| private IAsyncOperationSmartScopeValidator _asyncOperationSmartScopeValidator; |
|
|
||
| private IAuthorizationService<DataActions> _authorizationService; | ||
| private IQueueClient _queueClient; | ||
| private IAsyncOperationSmartScopeValidator _asyncOperationSmartScopeValidator; |
Comment on lines
+63
to
+69
| foreach (string requiredResourceType in requiredResourceTypes) | ||
| { | ||
| if (!IsExportReadScopeSatisfied(accessControlContext, requiredResourceType)) | ||
| { | ||
| throw new UnauthorizedFhirActionException(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this PR.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)