feat: configure streamed hydration behavior#7557
Open
janechu wants to merge 2 commits into
Open
Conversation
Add a hydration configuration option that keeps the hydration hook active for streamed Declarative Shadow DOM after the initial hydration batch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds hydration configuration for streamed Declarative Shadow DOM:
noopAfterHydrationCompletetoenableHydration()so streaming apps can keep hydration active after the initial batch.hydrationComplete.👩💻 Reviewer Notes
Please review the default no-op behavior versus
noopAfterHydrationComplete: falsefor streamed DSD scenarios.📑 Test Plan
npm run build✅npm run biome:check✅npm run checkchange✅npx playwright test src/components/hydration.pw.spec.tsfrompackages/fast-element✅npx playwright test --config=playwright.declarative.config.ts test/declarative/fixtures/ecosystem/hydration-config/hydration-config.spec.tsfrompackages/fast-element✅npm run test❌ failed in@microsoft/fast-test-harnessFirefox tests with 5s navigation/setup timeouts unrelated to the hydration changes.✅ Checklist
General
$ npm run change