fix(fast-element): harden DOM policy defaults#7551
Draft
janechu wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Hardens FAST Element DOM policy defaults by preserving default DOM element guards when partial element guard configs are provided and strengthening
safeURLhandling for mixed-case, whitespace/control-obscured, and percent-encoded unsafe protocols. The PR adds focused DOM policy tests and documents guard merging/security behavior.📑 Test Plan
npx biome check packages\fast-element\src\dom-policy.ts packages\fast-element\src\dom-policy.pw.spec.tsnpm run build:tsc -w @microsoft/fast-elementnpx playwright test dom-policy.pw.spec.ts --project=chromium✅ Checklist
General
$ npm run change