feat(component query): bulk spec querying with --arch enforcement by liunan-ms · Pull Request #204 · microsoft/azure-linux-dev-tools

liunan-ms · 2026-05-21T21:03:16Z

Introduces azldev component query for bulk-querying rendered RPM specs inside a single shared mock chroot, with arch-aware policy enforcement.

CLI

New azldev component query command — selects components via the standard component filter, renders results as a table / CSV / Markdown / JSON.
New --arch flag (default x86_64, also accepts aarch64) driving rpmspec --target=<arch> and ExclusiveArch/ExcludeArch policy.

Docs

CLI reference under docs/user/reference/cli/ regenerated.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates azldev component query to operate on locally rendered specs and to batch rpmspec execution in a shared mock chroot, including reporting binary subpackages.

Changes:

Added batched spec querying via an embedded Python helper and shared Go scaffolding for running batch scripts in mock.
Extended spec query results to include binary subpackages and updated tests to validate subpackage extraction.
Updated CLI help/docs and adjusted component query to require and validate rendered-specs-dir.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
scenario/internal/projecttest/testspec.go	Adds subpackage rendering support in test spec generation.
scenario/component_query_test.go	Updates scenario test to render first and validate subpackages in query output.
internal/rpm/specquery.go	Exposes rpmspec queryformat constants and adds subpackage parsing helper.
internal/rpm/specquery_test.go	Adds unit tests for subpackage-output parsing and SRPM parsing behavior.
internal/app/azldev/core/sources/specquery.go	Introduces batch spec query orchestration and input validation.
internal/app/azldev/core/sources/specquery_test.go	Adds tests for batched query JSON parsing and validation.
internal/app/azldev/core/sources/query_process.py	Implements parallel per-spec rpmspec execution inside mock chroot.
internal/app/azldev/core/sources/mockprocessor.go	Refactors shared batch-script runner and adds configurable required package install.
internal/app/azldev/command.go	Emits partial results even when a command returns an error, with typed-nil guarding.
internal/app/azldev/cmds/component/query.go	Reworks `component query` to read rendered specs and use batched rpmspec querying.
internal/app/azldev/cmds/component/mockproc.go	Centralizes mock required-package presets and mock processor creation.
internal/app/azldev/cmds/component/query_test.go	Updates query command tests for rendered-specs-dir validation behavior.
internal/app/azldev/cmds/component/query_internal_test.go	Adds internal tests for building batch query inputs and skip behavior.
docs/user/reference/cli/azldev_component_query.md	Updates CLI reference to match rendered-spec-based query and new `--arch` flag.
docs/user/reference/cli/azldev_component.md	Updates command list description for `component query`.

liunan-ms · 2026-05-21T22:24:59Z


 [distros.azurelinux.versions.'4.0'.default-component-config]
-spec = { type = "upstream", upstream-distro = { name = "fedora", version = "42" } }
+spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" } }


java-srpm-macros is not available in f42 as a standalone binary RPM. Bumping the test mock to releasever=43 (and the matching f43-build URL) to unblock the scenario tests.

… enforcement Add an --arch flag to 'component query' (default x86_64) that drives rpmspec's --target and enforces ExclusiveArch/ExcludeArch policy via a probe queryformat wrapped around the srpm query. Specs excluded by the selected arch surface as ExcludedFromArch entries and are summarized in a per-run log line. Harden the per-spec query subprocess: - 180s rpmspec timeout with a dedicated _RpmspecTimeout exception - UTF-8 decoding with errors=replace on file IO and subprocess output Plumb the arch parameter through BatchQuerySpecs and add ExcludedFromArch to SpecQueryResult / its JSON mapping. Teach runFuncInternal to render partial results when the inner func returns both a value and an error, so per-component query failures still print the successful rows while exiting non-zero. Add javapackages-common to the mock package list so %javadoc_package (from macros.fjava) doesn't silently disappear. Bump scenario AZL 4.0 upstream + mock releasever to Fedora 43; java-srpm-macros is missing from f42-build koji. Regenerate CLI docs.

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

+	if strings.Contains(cleaned, "..") {
+		return fmt.Errorf("spec path %#q must not contain path traversal", relPath)


+}
+
+// validateSpecRelPath rejects spec relative paths that could escape the
+// specs-dir bind mount or contain control characters.


+	if strings.ContainsRune(relPath, 0) {
+		return fmt.Errorf("spec path %#q must not contain null bytes", relPath)
+	}


+// "<spec name>-<suffix>") to the spec. The subpackage shares the main
+// package's installed file so that rpmbuild would also be happy with it.


+
+Usage::
+
+    python3 query_process.py <scratch_dir> <specs_dir> <max_workers>


reubeno · 2026-05-27T21:32:51Z

@dmcilvaney would you mind reviewing this? You'll be most familiar with the parts that touch the parallel mock processor.

Copilot AI review requested due to automatic review settings May 21, 2026 21:03

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread internal/app/azldev/command.go

Comment thread internal/app/azldev/core/sources/specquery.go

Comment thread internal/app/azldev/cmds/component/mockproc.go Outdated

Comment thread scenario/internal/projecttest/testspec.go

liunan-ms force-pushed the liunan/specquery branch from a6a9778 to abb1a51 Compare May 21, 2026 22:12

liunan-ms commented May 21, 2026

View reviewed changes

reubeno and others added 2 commits May 27, 2026 16:43

draft: bulk spec querying

5043a57

Copilot AI review requested due to automatic review settings May 27, 2026 16:57

liunan-ms force-pushed the liunan/specquery branch from abb1a51 to 090fa31 Compare May 27, 2026 16:57

Copilot AI reviewed May 27, 2026

View reviewed changes

reubeno requested a review from dmcilvaney May 27, 2026 21:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(component query): bulk spec querying with --arch enforcement#204

feat(component query): bulk spec querying with --arch enforcement#204
liunan-ms wants to merge 2 commits into
microsoft:mainfrom
liunan-ms:liunan/specquery

liunan-ms commented May 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liunan-ms May 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

reubeno commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if strings.Contains(cleaned, "..") {
		return fmt.Errorf("spec path %#q must not contain path traversal", relPath)

		// "<spec name>-<suffix>") to the spec. The subpackage shares the main
		// package's installed file so that rpmbuild would also be happy with it.


		Usage::

		python3 query_process.py <scratch_dir> <specs_dir> <max_workers>

Conversation

liunan-ms commented May 21, 2026

CLI

Docs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liunan-ms May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

reubeno commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants