Remove ServiceDefaults project from the aspire init output in "Add Aspire to an existing app"#1340
Open
alistairmatthews wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Add Aspire to an existing app” getting-started article to better reflect the current aspire init output for a solution-based (project-based) AppHost by removing the implied ServiceDefaults project and correcting the AppHost source file name.
Changes:
- Removes
MyApp.ServiceDefaults/from the “typical solution layout” tree under the Project-based AppHost section. - Updates the AppHost file shown in the solution layout from
Program.cstoAppHost.cs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
243
to
+247
| <FileTree> | ||
| - MyApp.sln | ||
| - MyApp.AppHost/ | ||
| - MyApp.AppHost.csproj | ||
| - Program.cs | ||
| - MyApp.ServiceDefaults/ | ||
| - MyApp.ServiceDefaults.csproj | ||
| - Extensions.cs | ||
| - AppHost.cs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Add Aspire to an existing app article, in the Project-based AppHost section, the typical solution layout includes a Service Defaults project.
I've just reconstructed the described steps and no ServiceDefaults project was generated. The PR removes that from the typical solution layout and also correct AppHost/Program.cs to AppHost/AppHost.cs.
Fixes: #1270