Fix infinite loop#63581
Open
core-dumpling wants to merge 1 commit into
Open
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a parser/scanner hang triggered by certain JSDoc comment contents ending in -*/ (e.g. /**a-*/), by fixing operator-precedence in the identifier scanning loop so the pos < end guard correctly applies to both identifier-part scanning and the special - allowance.
Changes:
- Fixes the
whilecondition inscanJsDocTokensochar === CharacterCodes.minuscan’t keep the loop running afterposhas reachedend.
| if (isIdentifierStart(ch, languageVersion)) { | ||
| let char = ch; | ||
| while (pos < end && isIdentifierPart(char = codePointUnchecked(pos), languageVersion) || char === CharacterCodes.minus) pos += charSize(char); | ||
| while (pos < end && (isIdentifierPart(char = codePointUnchecked(pos), languageVersion) || char === CharacterCodes.minus)) pos += charSize(char); |
Member
There was a problem hiding this comment.
+1, this needs a testcase
RyanCavanaugh
requested changes
Jun 24, 2026
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
Member
There was a problem hiding this comment.
Please add a test. Thanks!
github-project-automation
Bot
moved this from Not started
to Waiting on author
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63580