Skip to content

fix: typos and redundant null checks in ConditionallySetupDataverse #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
summitbaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: typos and redundant null checks in ConditionallySetupDataverse #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerApps.TestEngine/Config/TestSettingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class TestSettingExtensions
#endif

/// <summary>
/// List of allowed .Net Namespaces that deney load unless explict allow is defined
/// List of allowed .Net Namespaces that deny load unless explicit allow is defined
/// </summary>
public HashSet<string> DenyNamespaces { get; set; } = new HashSet<string>();

Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.PowerApps.TestEngine/PowerFx/PowerFxEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,13 @@ private CultureInfo GetLocaleFromTestSettings(string strLocale)
/// </summary>
private void ConditionallySetupDataverse(TestSettings testSettings, PowerFxConfig powerFxConfig)
{
if (testSettings == null || !testSettings.ExtensionModules.Parameters.ContainsKey(ENABLE_DATAVERSE_FUNCTIONS) || (testSettings != null && testSettings.ExtensionModules.Parameters[ENABLE_DATAVERSE_FUNCTIONS].ToString().ToLower() != "true"))
if (testSettings == null || !testSettings.ExtensionModules.Parameters.ContainsKey(ENABLE_DATAVERSE_FUNCTIONS) || testSettings.ExtensionModules.Parameters[ENABLE_DATAVERSE_FUNCTIONS].ToString().ToLower() != "true")
{
return;
}

// Must have dataverse enabled to enable AI Functions
if (testSettings != null && testSettings.ExtensionModules.Parameters.ContainsKey(ENABLE_AI_FUNCTIONS) && testSettings.ExtensionModules.Parameters[ENABLE_AI_FUNCTIONS].ToString().ToLower() == "true")
if (testSettings.ExtensionModules.Parameters.ContainsKey(ENABLE_AI_FUNCTIONS) && testSettings.ExtensionModules.Parameters[ENABLE_AI_FUNCTIONS].ToString().ToLower() == "true")
{
enableAIFunctions = true;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.PowerApps.TestEngine/SingleTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,13 @@ public async Task RunTestAsync(string testRunId, string testRunDirectory, TestSu
}
catch (Exception ex)
{
// That failed warn that faild but allow to continue so that can perform negative tests
// That failed warn that failed but allow to continue so that can perform negative tests
// For example the test could fail because the user is Unlicensed or the app is not shared with test user persona

// In the example of a canvas application Power Fx test steps like the following could be added for error dialog
// Assert(ErrorDialogTitle="Start a Power Apps trial?")
Logger.LogError(ex, "Found error setting up initial provider state");
Logger.LogInformation("Error found during login, proceeding wuth test");
Logger.LogInformation("Error found during login, proceeding with test");
}
}
else
Expand Down