Skip to content

Re-enable Tests-NewObjects-Internal disabled tests#9423

Open
aholstrup1 wants to merge 1 commit into
mainfrom
aholstrup1-automatic-disco
Open

Re-enable Tests-NewObjects-Internal disabled tests#9423
aholstrup1 wants to merge 1 commit into
mainfrom
aholstrup1-automatic-disco

Conversation

@aholstrup1

@aholstrup1 aholstrup1 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What & why

This re-enables the previously disabled tests in Tests-NewObjects-Internal by removing the Tests-NewObjects-Internal.DisabledTest.json file. That file was skipping 11 test methods (10 in Test Granules and 1 in Cloud Migration Property Test). Deleting it lets those tests run again in CI.

Linked work

Fixes #

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

Change is limited to deleting a disabled-tests manifest, which re-enables existing tests. No new code or tests added. CI will now exercise the re-enabled tests.

Risk & compatibility

The re-enabled tests may surface failures if the underlying issues that led to their being disabled are still present. Watch the CI run for these test methods.

Remove Tests-NewObjects-Internal.DisabledTest.json to re-enable the previously disabled tests.
@aholstrup1 aholstrup1 requested review from a team July 14, 2026 11:24
@github-actions

Copy link
Copy Markdown
Contributor

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: not-applicable

The PR diff against origin/main contains a single change: the deletion of src/DisabledTests/Tests-NewObjects-Internal/Tests-NewObjects-Internal.DisabledTest.json, a JSON test-exclusion manifest. No AL source file is touched. Every al-code-review leaf sub-skill requires AL code (technologies: [al]) with domain-specific signals (test attributes, permission logic, HTTP calls, UI controls, etc.) in the diff to build a non-empty worklist; none is present, so each sub-skill returned outcome not-applicable.

Knowledge source: https://github.com/microsoft/BCQuality@be1b92b624679f8c031061602e7d3a3b5f71a688

No findings were posted for this iteration.

Orchestrator pre-filter (16 file(s) excluded)

  • layer-disabled (knowledge) : 16 file(s)

Findings produced by the Copilot CLI agent against BCQuality at be1b92b624679f8c031061602e7d3a3b5f71a688. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant