Skip to content

[ALAppExtensions #30294][Event Change Request] Report 12121 "G/L Book - Print" - "OnPreDataItemOnAfterSetGLBookEntryFilters"#9415

Open
Explorer986 wants to merge 2 commits into
mainfrom
private/kumarjatin/640953
Open

[ALAppExtensions #30294][Event Change Request] Report 12121 "G/L Book - Print" - "OnPreDataItemOnAfterSetGLBookEntryFilters"#9415
Explorer986 wants to merge 2 commits into
mainfrom
private/kumarjatin/640953

Conversation

@Explorer986

@Explorer986 Explorer986 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What & why

Adds a new OnPreDataItemOnAfterSetGLBookEntryFilters integration event to report 12121 "G/L Book - Print". It is raised in OnPreDataItem() right after the standard GLBookEntry filters are set and before the FindFirst() gap check raises its error, so partners can add their own filter to GLBookEntry before that validation runs. Additive publisher only - no behavior change when unsubscribed.

Linked work

Fixes AB#640953

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

  • Diff review: one event-raise call plus one [IntegrationEvent] publisher; control flow is unchanged when no subscriber is present.
  • No tests added: a new integration-event publisher introduces no runtime behavior on its own.

Risk & compatibility

Very low. New publisher only; no existing event signatures changed, no schema change, no data/upgrade impact.

…fterSetGLBookEntryFilters event (AB#640953, ALAppExtensions #30294)
@Explorer986 Explorer986 requested a review from a team July 14, 2026 10:26
@Explorer986 Explorer986 added the Finance GitHub request for Finance area label Jul 14, 2026
@github-actions github-actions Bot modified the milestone: Version 29.0 Jul 14, 2026
Comment thread src/Layers/IT/BaseApp/Local/Finance/GeneralLedger/Reports/GLBookPrint.Report.al Outdated
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 2 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

…y to SourceGLBookEntry to avoid shadowing the global (CI AA0202)
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR adds the OnPreDataItemOnAfterSetGLBookEntryFilters integration event to report 12121 "G/L Book - Print". It is raised in the GL Book Entry dataitem OnPreDataItem trigger after the standard check-record filters are set and before FindFirst() can raise the previous-period-not-printed error.

The publisher uses [IntegrationEvent(false, false)] and passes the filtered check record by var, so a subscriber can narrow that record before the validation runs. It also passes the dataitem record by var for context or extra filters. There is no existing event signature change, and without subscribers the report keeps the same flow.

Suggestions

None.

Risk assessment and necessity

Risk: Low. This is one local event publisher and one event call in the Italian G/L Book - Print report. The main compatibility surface is intentional: subscribers can change the filtered check record before the existing error check runs. There is no schema change, no upgrade impact, and no behavior change when no subscriber exists.

Necessity: The linked event request needs a hook before the existing gap check. Without this event, partners must customize or copy the report to add their own GLBookEntry filter before the error. The scope is right for the request, and missing tests are acceptable for this pure event addition.


[AI-PR-REVIEW] version=1 system=github pr=9415 round=1 by=alexei-dobriansky at=2026-07-14T11:07:23Z lastSha=974eaa9729a25142c1bf8e2ed4f4dd73c80d3401 suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants