Add ACR cache-hit checks to avoid Docker Hub rate limits on Nexus image pulls#4918
Draft
Copilot wants to merge 2 commits into
Draft
Add ACR cache-hit checks to avoid Docker Hub rate limits on Nexus image pulls#4918Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
- devops/scripts/bundle_runtime_image_build.sh: before az acr import, query ACR for the target tag; skip the import if it already exists. Errors from the query (e.g. repository not yet created) are suppressed intentionally so that any real auth/network failure is surfaced by the subsequent az acr import command. - templates/shared_services/sonatype-nexus-vm/scripts/deploy_nexus_container.sh: after successful ACR login, run `docker manifest inspect` on the target image; exit immediately with a clear diagnostic message if the image is absent from ACR instead of silently falling back to Docker Hub.
Copilot
AI
changed the title
[WIP] Reexamine Nexus image pull process due to rate limits
Add ACR cache-hit checks to avoid Docker Hub rate limits on Nexus image pulls
May 27, 2026
Collaborator
|
/test-extended 84b2c45 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/26521694588 (with refid (in response to this comment from @rudolphjacksonm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pipeline run unconditionally calls
az acr importfor the Nexus image, hitting Docker Hub even when the image is already cached in ACR. This causes intermittent429: TOOMANYREQUESTSfailures that block CI for up to 6 hours.What is being addressed
bundle_runtime_image_build.shalways imports from Docker Hub on every publish, regardless of whether the image already exists in ACR.deploy_nexus_container.shproceeds directly todocker pullwith no preflight check, giving a confusing retry-then-timeout failure if the image was never imported.How is this addressed
devops/scripts/bundle_runtime_image_build.sh— beforeaz acr import, query ACR for the target tag and skip the import if it already exists:Query errors (repository not yet created, transient network blip) are suppressed so execution falls through to the import, which will surface real auth/network failures.
templates/shared_services/sonatype-nexus-vm/scripts/deploy_nexus_container.sh— after ACR login succeeds, rundocker manifest inspectbefore entering the pull retry loop. Exits immediately with a clear diagnostic if the image is absent: