Skip to content

Michael Myaskovsky via Elementary: Rename tag: finance → fin#238

Open
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-rename-finance-tag-to-fin-1c1524b6-8d8c-41ec-ae84-31cc48768f66
Open

Michael Myaskovsky via Elementary: Rename tag: finance → fin#238
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-rename-finance-tag-to-fin-1c1524b6-8d8c-41ec-ae84-31cc48768f66

Conversation

@elementary-data-local

Copy link
Copy Markdown

Renames the finance tag to fin across all 4 affected models:

  • orders
  • returned_orders
  • stg_orders
  • stg_payments

Also updates the cheat sheet reference files for consistency.

Created by: michael@elementary-data.com

@github-actions

Copy link
Copy Markdown

The tag finance still exists in the environment (other assets still use it), and fin does not yet appear — meaning this rename is partial and will create a split/inconsistent tagging scheme.


Tag Rename: financefin

Risk: Medium

  • The tag finance is still active in this environment — other assets not touched by this PR continue to use it. Renaming only orders, returned_orders, stg_orders, and stg_payments creates a split tagging scheme where "finance" assets are spread across two different tags (finance and fin).
  • Any tag-based alert routing rules, dbt selectors (tag:finance), or BI filters that target the finance tag will silently stop matching these four models after merge.
  • The tag fin does not currently exist in the environment — this PR would introduce it as a net-new tag with no existing consumers.

Recommendation: Confirm this is an intentional full migration of all finance-tagged assets, not just a subset. If it is a full migration, ensure all remaining finance-tagged assets are updated in the same PR. If it's partial/intentional, document why these models diverge from the rest.

No SQL changes, no downstream column impact, no schema risk.

Posted by Elementary CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants