test

[michael-myaskovsky]

No description provided.

[github-actions]

customers — PR Review

⚠️ Breaking Change: LEFT JOIN → INNER JOIN on customer_orders

This is the most significant risk in this diff. Switching to an INNER JOIN will silently drop any customer who has no orders. Depending on data, this could mean:

• Customers who signed up but never placed an order are excluded from the output.
• number_of_orders, first_order, most_recent_order, and customer_lifetime_value previously returned NULL for these customers — they will now disappear entirely from the table.

The existing anomaly monitors (row_count_anomalies, null_count_anomalies on number_of_orders and customer_lifetime_value) will catch this if the row count drops or null rates shift — but only after the model runs. The monitors currently show no_data status, so there's no baseline yet to trigger an alert.

Confirm this is intentional: is the intent to only expose customers with at least one order? If so, the model description ("basic information about a customer") and any downstream consumers may need to be updated to reflect the scope change.

Tests & Monitors

• row_count_anomalies, null_count_anomalies (on number_of_orders, customer_lifetime_value): all no_data — no baseline trained yet, so the monitors won't catch a drop on first run.
• dimension_anomalies on first_order: last execution was skipped.

Consider running the model in a dev environment and validating row counts against the current production table before merging.

Downstream Impact

No downstream assets. The blast radius is limited to this model only.

Anti-Pattern Warnings

The self_join warnings on customer_orders and customer_payments are likely false positives from the CTEs being referenced in the same final SELECT. Not actionable. The SELECT * warning can be ignored if column selection is intentional.

---

Risk: 🟠 Medium. The INNER JOIN change is a data-reducing semantic change that could silently exclude customers. No downstream breakage, but the behavior change warrants explicit confirmation before merge.

Posted by Elementary CI