Skip to content

Noy Arie via Elementary: Create new dbt tests.#236

Open
elementary-data-dev[bot] wants to merge 1 commit into
mainfrom
elementary-create-dbt-tests-20260713075231883885
Open

Noy Arie via Elementary: Create new dbt tests.#236
elementary-data-dev[bot] wants to merge 1 commit into
mainfrom
elementary-create-dbt-tests-20260713075231883885

Conversation

@elementary-data-dev

Copy link
Copy Markdown

Elementary: This PR updates your dbt tests according to changes made in Elementary's UI.


Created by: noy@elementary-data.com

@github-actions

Copy link
Copy Markdown

PR Review: Add dbt_utils.equal_rowcount test to customers

Change: Adds a model-level dbt_utils.equal_rowcount test asserting that customers and orders have the same row count, with severity: error.

⚠️ Test Logic Concern

This assertion is likely incorrect by design. customers is a deduplicated customer table (one row per customer), while orders contains one row per order — a customer can have many orders. These two tables are not expected to have equal row counts; in fact, orders is intentionally larger. This test will fail on any realistic dataset.

Verify the intent: if the goal is to ensure every customer has at least one order (or vice versa), the right test would be a referential integrity check (e.g., dbt_utils.relationships), not equal_rowcount.

Downstream Impact

No downstream assets depend on customers — blast radius is zero.

Tests & Incidents

No recent incidents on customers. Existing tests (anomaly detection on customers, column/dimension anomalies on orders) are all passing or skipped.


Risk: 🟡 Medium — The change itself is low-risk structurally, but the test semantics appear incorrect and will likely produce persistent ERROR-severity failures in CI/CD on every run. Recommend confirming the intended assertion before merging.

Posted by Elementary CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant