You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: Add dbt_utils.equal_rowcount test to customers
Change: Adds a model-level dbt_utils.equal_rowcount test asserting that customers and orders have the same row count, with severity: error.
⚠️ Test Logic Concern
This assertion is likely incorrect by design. customers is a deduplicated customer table (one row per customer), while orders contains one row per order — a customer can have many orders. These two tables are not expected to have equal row counts; in fact, orders is intentionally larger. This test will fail on any realistic dataset.
Verify the intent: if the goal is to ensure every customer has at least one order (or vice versa), the right test would be a referential integrity check (e.g., dbt_utils.relationships), not equal_rowcount.
Downstream Impact
No downstream assets depend on customers — blast radius is zero.
Tests & Incidents
No recent incidents on customers. Existing tests (anomaly detection on customers, column/dimension anomalies on orders) are all passing or skipped.
Risk: 🟡 Medium — The change itself is low-risk structurally, but the test semantics appear incorrect and will likely produce persistent ERROR-severity failures in CI/CD on every run. Recommend confirming the intended assertion before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elementary: This PR updates your dbt tests according to changes made in Elementary's UI.
Created by:
noy@elementary-data.com