Skip to content

breaking change#235

Open
michael-myaskovsky wants to merge 1 commit into
mainfrom
breaking-change
Open

breaking change#235
michael-myaskovsky wants to merge 1 commit into
mainfrom
breaking-change

Conversation

@michael-myaskovsky

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR Review: stg_orderscustomer_idclient_id rename

Risk: 🔴 HIGH — breaking column rename with wide downstream impact

Downstream Impact

The rename from customer_id to client_id is a breaking change. The old column name is actively referenced across 5 downstream columns in 4 models:

Model Column referencing customer_id
orders customer_id (hop 1)
artificial_anomaly customer_id (hop 2)
returned_orders customer_id (hop 2)
date_based_anomaly customer_id (hop 2)
forced_anomaly customer_id (hop 2)

Additionally, customers, date_orders, and 3 further hop-2 models (return_rate_anomaly, returned_orders_anomaly) depend on stg_orders and may also reference this column indirectly.

Unless all downstream models are updated in this same PR to use client_id, this will break at build time.

Tests

  • 3rd_test (singular dbt test on stg_orders) is currently in ERROR status and its query explicitly references orders.customer_id. After this rename, it will continue to fail — this test needs to be updated alongside the rename.

Summary

Do not merge as-is. This rename requires coordinated updates to all downstream models that reference customer_id and to the 3rd_test singular test. Confirm all dependent models are updated in this PR before approving.

Posted by Elementary CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant