breaking change#235
Open
michael-myaskovsky wants to merge 1 commit into
Open
Conversation
PR Review:
|
| Model | Column referencing customer_id |
|---|---|
orders |
customer_id (hop 1) |
artificial_anomaly |
customer_id (hop 2) |
returned_orders |
customer_id (hop 2) |
date_based_anomaly |
customer_id (hop 2) |
forced_anomaly |
customer_id (hop 2) |
Additionally, customers, date_orders, and 3 further hop-2 models (return_rate_anomaly, returned_orders_anomaly) depend on stg_orders and may also reference this column indirectly.
Unless all downstream models are updated in this same PR to use client_id, this will break at build time.
Tests
3rd_test(singular dbt test onstg_orders) is currently in ERROR status and its query explicitly referencesorders.customer_id. After this rename, it will continue to fail — this test needs to be updated alongside the rename.
Summary
Do not merge as-is. This rename requires coordinated updates to all downstream models that reference customer_id and to the 3rd_test singular test. Confirm all dependent models are updated in this PR before approving.
Posted by Elementary CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.