Skip to content

Optimize packetScoreInt by using only float, not double #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toofishes wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −4
Open

Optimize packetScoreInt by using only float, not double #2723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/helpers/radiolib/RadioLibWrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ static float snr_threshold[] = {
};

float RadioLibWrapper::packetScoreInt(float snr, int sf, int packet_len) {
if (sf < 7) return 0.0f;
if (sf < 7 || sf > 12) return 0.0f;

if (snr < snr_threshold[sf - 7]) return 0.0f; // Below threshold, no chance of success

auto success_rate_based_on_snr = (snr - snr_threshold[sf - 7]) / 10.0;
auto collision_penalty = 1 - (packet_len / 256.0); // Assuming max packet of 256 bytes
auto success_rate_based_on_snr = (snr - snr_threshold[sf - 7]) * 0.1f;
auto collision_penalty = 1 - (packet_len / 256.0f); // Assuming max packet of 256 bytes

return max(0.0, min(1.0, success_rate_based_on_snr * collision_penalty));
return max(0.0f, min(1.0f, success_rate_based_on_snr * collision_penalty));
}