Skip to content

Stop re-wrapping APIError as RequestError in AsyncSession #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BartWojtowicz wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

Stop re-wrapping APIError as RequestError in AsyncSession #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mwapi/async_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ async def _request(self, method, params=None, auth=None):
raise ConnectionError(str(e)) from e
except aiohttp.TooManyRedirects as e:
raise TooManyRedirectsError(str(e)) from e
except APIError:
# Raised above for a JSON 'error' response. Let it propagate with its
# structured .code/.info/.content instead of re-wrapping as RequestError
# below (matches the synchronous Session, which raises it uncaught).
raise
except Exception as e:
raise RequestError(str(e)) from e

Expand Down