Skip to content

Add feature flag for Smartling integration work#3231

Draft
lilybarrett wants to merge 3 commits into
mainfrom
lb/add-feature-flag-for-smartling-integration-work
Draft

Add feature flag for Smartling integration work#3231
lilybarrett wants to merge 3 commits into
mainfrom
lb/add-feature-flag-for-smartling-integration-work

Conversation

@lilybarrett
Copy link
Copy Markdown
Contributor

Scope

We are beginning to build a Smartling integration to provide translations for DotCom pages.

Asana Ticket: https://app.asana.com/1/15492006741476/project/1213994587940653/task/1214847371994672?focus=true

Implementation

  • Made some changes to a fork of Laboratory here for it to be compatible with DotCom.
  • Added Laboratory library to DotCom, along with a new flag for upcoming integration work.

@lilybarrett lilybarrett requested a review from a team as a code owner June 4, 2026 19:02
@lilybarrett lilybarrett marked this pull request as draft June 4, 2026 19:15
@lilybarrett
Copy link
Copy Markdown
Contributor Author

When you navigate to localhost:4001/_flags, ideally you should see some UI for toggling the flag on and off. However, I only see the unrendered HTML. Curious if you have any insight/suggestions, @arkadyan or @thecristen?

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="description" content="">
    <meta name="author" content="">

    <link rel="stylesheet" href="/_flags/css/app.css">
    <title>Laboratory</title>
  </head>

  <body>
    <div class="window">
      <div class="window-header">
        <div class="window-title">Features</div>
      </div>
      <div class="window-body">
        <ul class="feature-rows">
          
            <li class="feature-row disabled">
              <div class="feature-name">Smartling translations</div>
              <div class="feature-description">Uses Smartling's translation workflows</div>
              <div class="button">
                
                  <form action="/_flags/enable/use_smartling_translations" method="post">
                      <input class="button-text" type="submit" value="Enable" />
                  </form>
                
              </div>
            </li>
          
        </ul>
      </div>
    </div>
  </body>
</html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant