SF2.0[fix]: Skipped Stops disappear when the schedule drifts into the past, even if the vehicle is still upstream#3230
Open
lvachon1 wants to merge 3 commits into
Open
SF2.0[fix]: Skipped Stops disappear when the schedule drifts into the past, even if the vehicle is still upstream#3230lvachon1 wants to merge 3 commits into
lvachon1 wants to merge 3 commits into
Conversation
…at we continue to show skipped stops that have predictions in the past, but the vehicle hasn't skipped yet on this trip
joshlarson
requested changes
Jun 5, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
I do think this change deserves a test in UpcomingDeparturesTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Skipped Stops disappear when the schedule drifts into the past, even if the vehicle is still upstream
Implementation
Removed time filtering from predicted schedules on trip details so that we continue to show skipped stops that have predictions in the past, but the vehicle hasn't skipped yet on this trip
Screenshots
Local ------------------------- Dev
How to test
Find a route with skipped stops, preferably a bus. Find a stop right before the skipped stops, watch a vehicle approach and confirm that the skipped stops do not disappear while the vehicle is still on it's way to your stop.
If there's a Red Sox home game, the 8, 19, 60, and 65 will be skipping stops around Fenway and you can use this link and vary the route between those to find a bus that is coming soon. I got lucky, these seem to be rather infrequent busses.
https://dev.mbtace.com/departures/?route_id=65&direction_id=1&stop_id=1806