fix app freeze#762
Open
digitaltom wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address intermittent “map freeze” behavior after backgrounding/resume and websocket reconnects by adding runtime watchdogs/recovery logic in the MapLibre initialization path and reducing heavy reinitialization work on reconnect.
Changes:
- Add visibility-based render/input watchdogs and recovery actions (handler cycling, synthetic pointer-up dispatch, optional forced WebGL context reset).
- Add WebGL context lost/restored event handling on the map canvas.
- On websocket reconnect, skip the heavy layer/style rebuild if the page was hidden since last connect.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| app/javascript/maplibre/map.js | Adds render heartbeat, WebGL context handlers, visibility watchdog, and input watchdog/recovery logic. |
| app/javascript/maplibre/controls/buttons/select.js | Replaces prior recoverHandlers() usage with direct “debugging” actions on select click. |
| app/javascript/channels/map_channel.js | Adds visibility tracking and conditionally skips reconnect rebuild; adds status messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+205
to
+211
| // Visibility watchdog — silently tracks map activity for 10s after resume so | ||
| // the input/render freeze toasts can include the diagnostic summary inline | ||
| // (no separate toast that would be clobbered by the freeze toast). | ||
| document.addEventListener('visibilitychange', () => { | ||
| if (document.visibilityState !== 'visible') return | ||
| // map.once('idle', recoverHandlers) | ||
| status('Visibility: visible', 'info', 'medium', 1000) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Please check again.
Comment on lines
+20
to
+24
| let remoteCursors = new Set() | ||
| let wasHiddenSinceLastConnect = false | ||
| document.addEventListener('visibilitychange', () => { | ||
| if (document.visibilityState === 'hidden') wasHiddenSinceLastConnect = true | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Please check again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.