[WIP] Add status codes to error objects#16
Conversation
ingalls
left a comment
ingalls
left a comment
There was a problem hiding this comment.
👍 This looks like a good first step!
there is a lot of duplicate code here to copy the status code into the error object, what would you think about making this a generic function.
IE a new function called HTTPError
looking something like:
HTTPError(text, res) -> returns err with status
then these could go back to being oneliners like
return callback(HTTPError('I AM AN ERROR', res));| if (res.statusCode !== 200) return cb(new Error(res.body)); | ||
| if (res.statusCode === 404) { | ||
| const error = new Error('404: Could not obtain auth list'); | ||
| error.status = res.statusCode; |
There was a problem hiding this comment.
Need to return the error here.
|
@ingalls great idea to make an HTTPError class! There is now an errors module in case we want to create other error classes in the future. Happy to make HTTPError it's own module if you think that's not a realistic possibility. Also not sure if we should throw an error if the response parameter is missing, or if we should just make the status code null if so (which is what I've done, since it seems strange to throw an error when creating an Error instance 😂). Happy to change that too. |
|
This is fantastic! Looks good to go to me! - Thanks a ton for adding tests |
2 participants
This is work in progress to add status codes to error objects, as proposed in #15.
Next steps
statusproperty on them? I'm not sure what it would be, if so, because those aren't related to http responsescc @ingalls