Fix crash on corrupt field number in FieldsReader::doc()#231
Open
Johnson-zs wants to merge 1 commit into
Open
Conversation
FieldsReader::doc() did not validate the field number read from the stored fields stream. When a corrupted index contained an invalid field number, the subsequent fieldInfo lookup returned a null pointer, causing a null-pointer dereference crash. Throw CorruptIndexException when the field number has no matching FieldInfo entry. Add a unit test (testCorruptFieldNumber) that constructs a corrupted fields file with an invalid VInt field number and verifies the exception is raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FieldsReader::doc() did not validate the field number read from the
stored fields stream. When a corrupted index contained an invalid
field number, the subsequent fieldInfo lookup returned a null pointer,
causing a null-pointer dereference crash.
Throw CorruptIndexException when the field number has no matching
FieldInfo entry. Add a unit test (testCorruptFieldNumber) that
constructs a corrupted fields file with an invalid VInt field number
and verifies the exception is raised.