Skip to content

header_parse to handle comment edge cases#62

Open
delphamk wants to merge 1 commit into
logos-co:masterfrom
delphamk:h_parser_edge
Open

header_parse to handle comment edge cases#62
delphamk wants to merge 1 commit into
logos-co:masterfrom
delphamk:h_parser_edge

Conversation

@delphamk
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the experimental implementation header parser so it can correctly detect public method declarations that include trailing // comments and declarations spanning multiple lines, and extends the existing complex fixture/test to cover those edge cases.

Changes:

  • Extend parseImplHeader to strip trailing // comments and accumulate multi-line declarations until ; is reached.
  • Add new method declarations (trailing-comment + multi-line) to the complex fixture header.
  • Add test assertions to ensure the newly introduced methods are parsed as public methods.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cpp-generator/experimental/impl_header_parser.cpp Accumulates multi-line declarations and strips trailing // comments before parsing method declarations.
tests/experimental/fixtures/complex_impl.h Adds public method declarations exercising trailing-comment and multi-line declaration parsing.
tests/experimental/test_impl_header_parser.cpp Adds assertions verifying the parser includes the new methods from the complex fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants