header_parse to handle comment edge cases#62
Open
delphamk wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the experimental implementation header parser so it can correctly detect public method declarations that include trailing // comments and declarations spanning multiple lines, and extends the existing complex fixture/test to cover those edge cases.
Changes:
- Extend
parseImplHeaderto strip trailing//comments and accumulate multi-line declarations until;is reached. - Add new method declarations (trailing-comment + multi-line) to the complex fixture header.
- Add test assertions to ensure the newly introduced methods are parsed as public methods.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cpp-generator/experimental/impl_header_parser.cpp |
Accumulates multi-line declarations and strips trailing // comments before parsing method declarations. |
tests/experimental/fixtures/complex_impl.h |
Adds public method declarations exercising trailing-comment and multi-line declaration parsing. |
tests/experimental/test_impl_header_parser.cpp |
Adds assertions verifying the parser includes the new methods from the complex fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.