Add support for RPC V2#1087
Open
1egoman wants to merge 15 commits into
Open
Conversation
|
Caution Breaking change detected without major changeset
If this is intentional, please add a changeset with |
Contributor
Author
|
^ In the above "breaking change" warning, it looks like the issue is: But it's a field addition... That shouldn't be a breaking change? Let me know what I am missing - I could I think make this private, but I'd need to verify that is ok first. |
1egoman
commented
May 15, 2026
Comment on lines
+70
to
+72
| final remoteParticipant = _room.getParticipantByIdentity(destination); | ||
| final remoteProtocol = remoteParticipant?.clientProtocol ?? ClientProtocolVersion.v0.toIntValue(); | ||
| final useV2 = remoteProtocol >= ClientProtocolVersion.v1.toIntValue(); |
Contributor
Author
There was a problem hiding this comment.
thought: I wonder if it would be cleaner to make ClientProtocolVersion implement Comparable (this) to avoid all the toIntValue()s here?
Comment on lines
26
to
35
| E2EContainer? container; | ||
| late Room room; | ||
|
|
||
| group('rpc tests', () { | ||
| test('test rpc handler register', () async { | ||
| container = E2EContainer(); | ||
| room = container!.room; | ||
| await container!.connectRoom(); | ||
|
|
||
| room.registerRpcMethod('echo', (RpcInvocationData data) async { |
Contributor
Author
There was a problem hiding this comment.
question: Heads up that I kept all the old / pre-existing rpc v1 tests around. I'm not sure though if this is really still needed, because the new tests should be testing all the same paths. I'll defer to what others think here, I don't have a strong opinion on if they should be kept or removed.
1egoman
requested review from
cloudwebrtc,
hiroshihorie and
xianshijing-lk
as code owners
This can be used to exercise sending / receiving rpc requests in the example app
…n livekit/protocol)
Add ClientProtocolVersion, and adds this to connectOptions. Just like the swift version, thie can be configured on connection for testing purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this pull request for more info about what this does and how rpc v2 works: livekit/client-sdk-js#1832
Also, for an in depth description of behavior in edge cases, see RPC_SPEC.md here.
Warning
This pull request was LLM generated and has only been lightly reviewed by the author, who is not a flutter expert. I have tested this and can confirm it works in the happy path, but no other validation has been done.
A more thorough review of this needs to occur before it could be merged.