Fix HVAC action mapping for eco/setback heating states#1488
Merged
Conversation
Map eco and setback heating states to OFF instead of HEATING
Contributor
Author
|
Could you please add the |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts HeatingCircuitStatus → HVACActionCategory mapping so eco/setback-related heating circuit statuses report as OFF (not active heating), improving the accuracy of HVAC action reporting for downstream consumers.
Changes:
- Adds missing
HeatingCircuitStatus.ROOM_TEMPERATURE_LIMIT(0x7A). - Moves
DAY_ECO,SETBACK_REDUCED,SETBACK_FROST_PROTECTION, andROOM_TEMPERATURE_LIMITto theOFFcategory mapping.
Comment on lines
+273
to
+276
| DAY_ECO = 0x77 | ||
| SETBACK_REDUCED = 0x78 | ||
| SETBACK_FROST_PROTECTION = 0x79 | ||
| ROOM_TEMPERATURE_LIMIT = 0x7A |
liudger
added
the
bugfix
liudger
approved these changes
May 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 6 6
Lines 1086 1087 +1
Branches 146 146
=======================================
+ Hits 1085 1086 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the HVAC action category mapping for several heating circuit status values in
constants.py.Changes
This PR:
adds the missing
ROOM_TEMPERATURE_LIMITstatus (0x7A)reclassifies the following statuses from
HEATINGtoOFF:DAY_ECOSETBACK_REDUCEDSETBACK_FROST_PROTECTIONROOM_TEMPERATURE_LIMITMotivation
These states indicate that active heating is not currently running, but they were previously categorized as
HVACActionCategory.HEATING.Mapping them to
OFFresults in more accurate HVAC action reporting and better reflects the actual operating state of the heating circuit.Testing
Tested locally against a BSBLAN installation and verified that the reported HVAC action now matches the expected heating circuit behavior.