feat(widget): add AppearanceChanged event for theme persistence#778
Open
effie-ms wants to merge 3 commits into
Open
feat(widget): add AppearanceChanged event for theme persistence#778effie-ms wants to merge 3 commits into
effie-ms wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: ce0c3ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
Base automatically changed from
fix/playground-theme-switch-height-reset
to
main
June 15, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
N/A — discovered during playground testing.
Why was it implemented this way?
NB: to be discussed
When users toggle light/dark/system in the widget's settings page, only MUI's internal
setMode()was called. The playground (host app) had no way to know the theme changed, so its persisted config kept the old appearance value and overwrote the user's choice on reload.This PR adds a new
WidgetEvent.AppearanceChangedevent emitted fromThemeSettingsaftersetMode(). The playground subscribes inWidgetViewand syncs its config store viasetAppearance(), which persists through Zustand'spersistmiddleware.Alternative considered: reading MUI's
li.fi-widget-modelocalStorage key during playground store rehydration. Rejected because the rehydration timing made it unreliable and it coupled the playground to the widget's internal MUI storage key.The event approach is cleaner — it works for any host app, not just the playground, and follows the existing widget event pattern.
Visual showcase (Screenshots or Videos)
N/A — behavior change: theme toggle in widget settings now persists across page reloads.
Checklist before requesting a review