Skip to content

Return time of the classical Harmonic oscillator (an open TODO from section F)#1201

Merged
jstoobysmith merged 8 commits into
leanprover-community:masterfrom
abudjum:master
Jun 18, 2026
Merged

Return time of the classical Harmonic oscillator (an open TODO from section F)#1201
jstoobysmith merged 8 commits into
leanprover-community:masterfrom
abudjum:master

Conversation

@abudjum

@abudjum abudjum commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hello,

I tried to solve an open TODO item from the Section F of Physlib.ClassicalMechanics.HarmonicOscillator.Solution which resulted in the following lemma:

Assuming that the initial coordinate and velocity are not simultaneously zero,
the time stamps when the harmonic oscillator returns to its initial coordinate and velocity is
a multiple of its period

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed.
If submitting to ./Physlib or ./QuantumInfo, please
see our review guidelines
if you are not familiar with the process. You should expect a back and forth
with a reviewer before your PR is merged. See also that link for how to
add appropriate labels to your PR. The PR will also go through a number
of automated checks. You can learn more about these here,
including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process,
though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this
thread of the Lean Zulip.

@abudjum abudjum changed the title Return time of the classical Harmonic oscillator (an open TODO from section 6) Return time of the classical Harmonic oscillator (an open TODO from section F) Jun 17, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but there are some stray spaces in this which are likely best removed.

Comment thread Physlib/ClassicalMechanics/HarmonicOscillator/Solution.lean Outdated
Comment thread Physlib/ClassicalMechanics/HarmonicOscillator/Solution.lean Outdated
Comment thread Physlib/ClassicalMechanics/HarmonicOscillator/Solution.lean Outdated
Comment thread Physlib/ClassicalMechanics/HarmonicOscillator/Solution.lean Outdated
@jstoobysmith jstoobysmith added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 18, 2026
@jstoobysmith

Copy link
Copy Markdown
Member

When these are addressed, please could you make a comment with a -awaiting-author to remove said label.

abudjum and others added 4 commits June 18, 2026 11:36
Co-authored-by: Joseph Tooby-Smith <72603918+jstoobysmith@users.noreply.github.com>
Co-authored-by: Joseph Tooby-Smith <72603918+jstoobysmith@users.noreply.github.com>
Co-authored-by: Joseph Tooby-Smith <72603918+jstoobysmith@users.noreply.github.com>
Co-authored-by: Joseph Tooby-Smith <72603918+jstoobysmith@users.noreply.github.com>
@abudjum

abudjum commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 18, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Many thanks for this first PR - hopefully the first of many :). This now looks good to me. I've approved and will merge shortly!

@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly t-classical-mechanics Classical mechanics labels Jun 18, 2026
@jstoobysmith jstoobysmith merged commit 5aaae8f into leanprover-community:master Jun 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-classical-mechanics Classical mechanics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants