feat: Stinespring dilation#1191
Conversation
|
Thank you for this PR, which will now be reviewed. If you are submitting to ./PhyslibAlpha there will be a lighter review process, If you want to bring attention to this PR, please write a message on this |
|
This is my fault, but one of the linters for PhyslibAlpha is broken - meaning it is not properly checking whether or not the file is correctly imported into ./PhyslibAlpha.lean. I've prepared a fix at #1193. But in the meantime - please can add to |
Sounds good, trying that! But I can't find a linter that picks up on the missing doc-strings, |
|
Ok, so what you have is technically not wrong, but your file here is missing a underneath your module doc-string will result in these been picked up in your linters. You can:
Which would you rather do? |
|
(2) sounds best since it'll improve the document in a straightforward way. |
jstoobysmith
left a comment
There was a problem hiding this comment.
Looks good to me now. Approved. Will merge shortly
Stinespring dilation theorem, finite-dimensional version.
One of the Top 100 Quantum Theorems from https://marcodavid.net/top100/