Add local CFT first-variation stack to PhyslibAlpha#1189
Merged
jstoobysmith merged 2 commits intoJun 15, 2026
Merged
Conversation
Contributor
|
Thank you for this PR, which will now be reviewed. Please If you want to bring attention to this PR, please write a message on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the local classical field theory stack into
PhyslibAlpha, following the discussion on the previous corePhyslibPR about developing this coordinate-first material in the Alpha area first.The development is based on the coordinate local setup used in Cortes--Haupt, arXiv:1612.03100v2: fields
Space d -> EuclideanSpace ℝ (Fin m), coordinate-level jet points, local Lagrangians, total derivatives, and the first-variation / Euler--Lagrange pipeline.The stack added here includes:
The underlying maintained
AdmissibleVariationstructure remains imported fromPhyslib; Alpha only adds the Euclidean component helper needed by this coordinate stack.Validation run locally:
lake build PhyslibAlpha.ClassicalFieldTheory.Local.FirstVariationlake build PhyslibAlphalake exe runPhyslibAlphaLinters./scripts/PhyslibAlpha/alphaFileImports.py./scripts/PhyslibAlpha/noAlphaImports.py./scripts/PhyslibAlpha/alphaPythonLinters.sh