docs: drop Miaoda brand word from apps command help text#1399
docs: drop Miaoda brand word from apps command help text#1399raistlin042 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR standardizes product-specific wording to vendor-neutral "app" or "lark" across shortcuts/apps: descriptions, flag help, DryRun strings, init commit subjects, tests, comments, and git-credential messages; credential validation gains a nil-issued check. No runtime behavior changed. ChangesTerminology Update Across App Shortcuts
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fdb5a37 to
cdbfe33
Compare
cdbfe33 to
83947a6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 731 731
Lines 69111 69111
=======================================
Hits 50335 50335
Misses 14999 14999
Partials 3777 3777 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@90fdfbdb0a49a0f95e6ff7d26831ebbe761c40be🧩 Skill updatenpx skills add larksuite/cli#docs/apps-help-drop-miaoda -y -g |
Summary
lark-cli appscommand help, runtime hints, and error messages embedded the pinyin brand word "Miaoda". When a user upgraded lark-cli but not the lark-apps skill (or the AI did not load it), the AI would "helpfully" mistranslate "Miaoda" into wrong Chinese names. Per the product team decision, the external product term is just "app", so this PR removes the "Miaoda" brand word across all apps command text (e.g. "Miaoda app" becomes "app"), removing the trigger for mistranslation.Changes
shortcuts/apps/: ShortcutDescription, flagDesc, the cobraShort, dry-run.Desc(...),hintconstants, andoutput.Errorf/gitCredentialLocalErrormessages (apps_create.go,apps_html_publish.go,git_credential.go,gitcred/helper.go,apps_db_*.go,apps_release_*.go,apps_session_*.go,apps_list.go,apps_update.go,apps_access_scope_*.go,common.go,html_publish_client.go, etc.)apps +initcommit-message constants inapps_init.go(initialize app config/initialize app repository)git_credential_test.go,apps_init_test.go)@lark-apaas/miaoda-cli, themiaoda-clitool references,https://miaoda.feishu.cnURLs, and existing Chinese text. These are identifiers/paths/localized strings, not the brand word in English help text.Test Plan
make unit-testpassed (go test ./shortcuts/apps/...green, incl. gitcred subpackage)apps --helpand subcommand help show "app",grep -i miaodaempty, wording natural)apps +create --help/apps +html-publish --helpcontain no "Miaoda";grep -rn "Miaoda" shortcuts/apps/returns emptyRelated Issues
N/A
Summary by CodeRabbit