Adopt liblsl v1.18.0.b2 and expose new API (reset_uid, sync outlet)#115
Open
cboulay wants to merge 4 commits into
Open
Adopt liblsl v1.18.0.b2 and expose new API (reset_uid, sync outlet)#115cboulay wants to merge 4 commits into
cboulay wants to merge 4 commits into
Conversation
Point the publish workflow at the liblsl v1.18.0.b2 prerelease, which ships correctly-versioned liblsl-1.18.0-* assets (and lsl.xcframework.1.18.zip).
Match the publish workflow so PR/push CI exercises the same beta liblsl that the release bundles.
Wraps the new lsl_reset_uid C function (sccn/liblsl#280), which regenerates a stream_info's UID. Useful for assigning a UID to a locally-constructed StreamInfo before it is bound to an outlet/inlet. Raises NotImplementedError on older liblsl that lacks the symbol.
Expose the lsl_transport_options_t flags (transp_default, transp_bufsize_samples, transp_bufsize_thousandths, transp_sync_blocking) and a transport_flags argument on StreamOutlet, routed through lsl_create_outlet_ex. transp_sync_blocking enables the new synchronous (zero-copy) outlet mode (sccn/liblsl#256) for high-bandwidth streams. Default behavior is unchanged (async via lsl_create_outlet).
cboulay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the liblsl
v1.18.0.b2prerelease and exposes the new functionality it adds.liblsl version bump
v1.18.0.b2(assets are correctly namedliblsl-1.18.0-*, macOSlsl.xcframework.1.18.zip).New API surface
StreamInfo.reset_uid()— wrapslsl_reset_uid(Allow UID to be reset via C API (extends #260) sccn/liblsl#280); regenerates a stream_info's UID. RaisesNotImplementedErroron liblsl < 1.18.0.StreamOutlet(..., transport_flags=...)— routed throughlsl_create_outlet_ex. Exposestransp_default,transp_bufsize_samples,transp_bufsize_thousandths, andtransp_sync_blocking(synchronous zero-copy outlet mode, Synchronous (Zero-Copy) Outlet Mode sccn/liblsl#256). Default behavior unchanged.Tests
test_info.py: reset_uid round-trip (skipped on < 1.18) + NotImplementedError path on older libs.test_outlet_transport.py: transport constants, default outlet, and sync round-trip (skipped on < 1.18).v1.18.0.b2macOS dylib: 16 passed, 1 skipped; ruff clean.The PR
pull_requesttrigger builds all platform wheels against b2 and runsuv publish --dry-run. No PyPI upload happens until a GitHub Release is published.